Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing time format on admin sales order grid #8336

Merged
merged 2 commits into from
Feb 3, 2017

Conversation

krejcif
Copy link
Contributor

@krejcif krejcif commented Jan 30, 2017

No description provided.

@vrann
Copy link
Contributor

vrann commented Jan 30, 2017

@magexo can you please provide the description of your fix, i.e. expected result vs actual result.

@vrann vrann self-assigned this Jan 30, 2017
@vrann vrann added the bugfix label Jan 30, 2017
@vrann
Copy link
Contributor

vrann commented Jan 30, 2017

@magexo verified the fix, here arebug description.

  • create customer, create product, create order
  • in admin backend navigate to Sales->Orders grid
  • see the date, i.e. "Jan 30, 2017, 16:01:00 PM"
  • open the order and check the date under "Order Date"

Expected result:

  • date is the same as on the grid

Actual result

  • date is different. I.e.: "Jan 30, 2017, 4:47:45 PM"

Note: date on the grid is wrong

Please correct me if it's not accurate

@krejcif
Copy link
Contributor Author

krejcif commented Jan 31, 2017

yes, that's it...

@mikeymike
Copy link

Just came across this by chance but if you merge this you're going to want to close this 4 month old PR doing the same thing

#6785

@mmansoor-magento mmansoor-magento merged commit 0de7c46 into magento:develop Feb 3, 2017
mmansoor-magento pushed a commit that referenced this pull request Feb 3, 2017
- covered additional numeric cases with the communication.xsd schema changes
- added integration tests
mmansoor-magento pushed a commit that referenced this pull request Feb 3, 2017
- add unit test for AbstractTemplate Exception
mmansoor-magento pushed a commit that referenced this pull request Feb 3, 2017
- disable static test check for long line in unit tests
mmansoor-magento pushed a commit that referenced this pull request Feb 3, 2017
- fix static test check for long line in unit tests
@vrann
Copy link
Contributor

vrann commented Feb 3, 2017

@magexo Thank you for the contribution!

@vrann
Copy link
Contributor

vrann commented Feb 3, 2017

@mikekeilty Thanks for contribution, accepted it here.

@heldchen
Copy link
Contributor

heldchen commented Feb 3, 2017

thanks @vrann!

@okorshenko okorshenko added this to the February 2017 milestone Feb 11, 2017
@vrann vrann added the simple label Mar 11, 2017
@danielerovatti
Copy link

@vrann bug is still present in v.2.1.5 in vendor/magento/module-sales/view/adminhtml/ui_component/sales_order_grid.xml

@vrann
Copy link
Contributor

vrann commented Apr 11, 2017

@danielerovatti that is expectable: this PR was accepted to the develop branch which will be the part of the 2.2 release. There is a separate process of the backporting to the 2.1 branch.

@fxdegroot
Copy link

fxdegroot commented Apr 18, 2017

It should actually be h:mm:ss A instead of H:mm:ss A

@OZZlE
Copy link
Contributor

OZZlE commented Aug 22, 2017

@vrann when will you backport this to 2.1? It's still present in 2.1.7 .... Since 2.2 is still in RC you should really be backporting bugs like these, especially when they are simple to fix..

@OZZlE
Copy link
Contributor

OZZlE commented Aug 29, 2017

A == AM/PM
Capital H == 24 hour formatted hour (which is not used with AM/PM)

so either the A should be removed or it should be lowercase h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants