-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing time format on admin sales order grid #8336
Conversation
Fixing bad date format on sales_order grid
@magexo can you please provide the description of your fix, i.e. expected result vs actual result. |
@magexo verified the fix, here arebug description.
Expected result:
Actual result
Note: date on the grid is wrong Please correct me if it's not accurate |
yes, that's it... |
Just came across this by chance but if you merge this you're going to want to close this 4 month old PR doing the same thing |
@magexo Thank you for the contribution! |
@mikekeilty Thanks for contribution, accepted it here. |
thanks @vrann! |
@vrann bug is still present in v.2.1.5 in vendor/magento/module-sales/view/adminhtml/ui_component/sales_order_grid.xml |
@danielerovatti that is expectable: this PR was accepted to the develop branch which will be the part of the 2.2 release. There is a separate process of the backporting to the 2.1 branch. |
It should actually be h:mm:ss A instead of H:mm:ss A |
@vrann when will you backport this to 2.1? It's still present in 2.1.7 .... Since 2.2 is still in RC you should really be backporting bugs like these, especially when they are simple to fix.. |
A == AM/PM so either the A should be removed or it should be lowercase h |
No description provided.